Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maya: make render settings validator optional #474

Merged
merged 6 commits into from
May 3, 2024
Merged

Maya: make render settings validator optional #474

merged 6 commits into from
May 3, 2024

Conversation

antirotor
Copy link
Member

Changelog Description

Make Render Settings validator otional

Testing notes:

  1. set render settings validator in Maya optional
  2. try to publish render

@antirotor antirotor added enhancement host: Maya sponsored This is directly sponsored by a client or community member labels Apr 30, 2024
@antirotor antirotor self-assigned this Apr 30, 2024
@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels Apr 30, 2024
@moonyuet
Copy link
Member

I also find out the enabled option for ValidatePluginPathAttributesModel might be wrong.(not related to this PR)

ayon-core/server_addon/maya/server/settings/publishers.py

Lines 239 to 246 in 9f4c701

class ValidatePluginPathAttributesModel(BaseSettingsModel):
"""Fill in the node types and attributes you want to validate.
<p>e.g. <b>AlembicNode.abc_file</b>, the node type is <b>AlembicNode</b>
and the node attribute is <b>abc_file</b>
"""
enabled: bool = True

@antirotor antirotor marked this pull request as ready for review April 30, 2024 15:27
@antirotor antirotor assigned LiborBatek and moonyuet and unassigned antirotor Apr 30, 2024
@antirotor
🐛 fix invalid enabled flag
5643cbb 
unrelated to the original PR, sorry
@antirotor
Copy link
Member Author

I also find out the enabled option for ValidatePluginPathAttributesModel might be wrong.(not related to this PR)

Unrelated, but fixed it here anyway, sorry about that.

moonyuet
moonyuet approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@moonyuet moonyuet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in Maya, one remark is that it would be great to have more concise label for the validator such as Validate Render Setting so that users know what the validator is enabled for the render instance when they are at the publish tab.

ayon-core/client/ayon_core/hosts/maya/plugins/publish/validate_rendersettings.py

Line 72 in b87e904

label = "Render Settings"

image

LiborBatek
LiborBatek approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as expected...

I have located the Validator and set it as Optional and it was available in the publisher UI and when my settings been wrong it correctly validated when enabled and vice versa....
Screenshot 2024-05-02 152503

Screenshot 2024-05-02 152828

Screenshot 2024-05-02 152854

Screenshot 2024-05-02 153044

@antirotor antirotor merged commit f6df3d1 into develop May 3, 2024
1 check failed
@antirotor antirotor deleted the enhancement/AY-1001_validate-render-settings-optional branch May 3, 2024 10:22
@antirotor antirotor restored the enhancement/AY-1001_validate-render-settings-optional branch May 3, 2024 10:56
@antirotor antirotor mentioned this pull request May 3, 2024
Merged
antirotor added a commit that referenced this pull request May 3, 2024
@antirotor
Merge pull request #481 from ynput/enhancement/AY-1001_validate-rende…
25c9481 
…r-settings-optional

Add default value for #474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigRoy BigRoy BigRoy requested changes

@LiborBatek LiborBatek LiborBatek approved these changes

@moonyuet moonyuet moonyuet approved these changes

Assignees

@moonyuet moonyuet

@LiborBatek LiborBatek

Labels
host: Maya size/XS sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition
Projects
PR reviewing
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@antirotor @moonyuet @BigRoy @LiborBatek @ynbot